comparison mercurial/commit.py @ 46679:d6fa9fbd375d stable

commit: reorder if-else conditional to give mergestate info priority

Looking at the code now, I was unable to find a good reason as why we only rely
on mergestate extras info after checking whether a filelog parent is ancestor of
other or not.

I mean if we have stored in mergestate that `other` was chosed, we should
blindly pick that one.

This cleanup will also help introduce more cases when both `fparent1` and
`fparent2` are non-null but using info from mergestate, we can fastpath.

The test change actually demonstrates the point of the patch. During merge we
were getting the other side of the file but on commit we were marking that as
merged.

Differential Revision: https://phab.mercurial-scm.org/D10147

46678:0d055849d5f9

            )

    elif fparent1 == nullid:
        fparent1, fparent2 = fparent2, nullid
    elif fparent2 != nullid:
        # is one parent an ancestor of the other?
        fparentancestors = flog.commonancestorsheads(fparent1, fparent2)
        if fparent1 in fparentancestors:
            fparent1, fparent2 = fparent2, nullid
        elif fparent2 in fparentancestors:
            fparent2 = nullid
        elif not fparentancestors:
            # TODO: this whole if-else might be simplified much more
            if (
                ms.active()
                and ms.extras(fname).get(b'filenode-source') == b'other'
            ):
                fparent1, fparent2 = fparent2, nullid

    force_new_node = False
    # The file might have been deleted by merge code and user explicitly choose
    # to revert the file and keep it. The other case can be where there is
    # change-delete or delete-change conflict and user explicitly choose to keep

46679:d6fa9fbd375d

            )

    elif fparent1 == nullid:
        fparent1, fparent2 = fparent2, nullid
    elif fparent2 != nullid:
        if ms.active() and ms.extras(fname).get(b'filenode-source') == b'other':
            fparent1, fparent2 = fparent2, nullid
        # is one parent an ancestor of the other?
        else:
            fparentancestors = flog.commonancestorsheads(fparent1, fparent2)
            if fparent1 in fparentancestors:
                fparent1, fparent2 = fparent2, nullid
            elif fparent2 in fparentancestors:
                fparent2 = nullid

    force_new_node = False
    # The file might have been deleted by merge code and user explicitly choose
    # to revert the file and keep it. The other case can be where there is
    # change-delete or delete-change conflict and user explicitly choose to keep