Mercurial > hg
comparison tests/test-ssh-bundle1.t @ 42897:d7304434390f
changegroup: move message about added changes to transaction summary
Before that, applying multiple changegroups in the same transaction issued the
message multiple time. This result in a confusing output:
adding changesets
adding manifests
adding file changes
added 32768 changesets with 60829 changes to 2668 files
adding changesets
adding manifests
adding file changes
added 8192 changesets with 16885 changes to 1553 files
adding changesets
adding manifests
adding file changes
added 1020 changesets with 1799 changes to 536 files
adding changesets
adding manifests
...
Instead, we now only issue the message once at the end of the transaction,
summing up all added changesets, changes and files. The line is identical, but
happens sightly later in the output.
There are other suboptimal behavior around issue multiple changegroup (eg:
progress bar). We'll cover them later.
This impact of lot of test as one would expect, but a two pass check show they
are just the order change we expected.
To deal with "under the hood" bundle application by internal code, we had to
take a slightly hacky move. We could clean that up with a more official way to
enter "under the hood" section, however I want to keep this series simple to get
it landed. This kind of change have a very high bit rot rate since it impact a
lot of test output.
author | Pierre-Yves David <pierre-yves.david@octobus.net> |
---|---|
date | Sun, 08 Sep 2019 09:42:53 +0200 |
parents | 94faa2e84094 |
children | edc8504bc26b |
comparison
equal
deleted
inserted
replaced
42896:7e19b640c53e | 42897:d7304434390f |
---|---|
581 pushing to ssh://user@dummy/remote | 581 pushing to ssh://user@dummy/remote |
582 searching for changes | 582 searching for changes |
583 remote: adding changesets | 583 remote: adding changesets |
584 remote: adding manifests | 584 remote: adding manifests |
585 remote: adding file changes | 585 remote: adding file changes |
586 remote: added 1 changesets with 1 changes to 1 files | |
587 remote: hook failure! | 586 remote: hook failure! |
588 remote: transaction abort! | 587 remote: transaction abort! |
589 remote: rollback completed | 588 remote: rollback completed |
590 remote: abort: pretxnchangegroup.fail hook failed | 589 remote: abort: pretxnchangegroup.fail hook failed |
591 [1] | 590 [1] |