Mercurial > hg
comparison mercurial/transaction.py @ 43106:d783f945a701
py3: finish porting iteritems() to pycompat and remove source transformer
This commit finishes porting .iteritems() to pycompat.iteritems()
for the mercurial package.
The translation of .iteritems() to .items() was the last conversion
performed by the source transformer. With the porting to pycompat
complete, we no longer have a need for the source transformer. So
the source transformer has been removed. Good riddance! The code
base is now compatible with Python 2 and Python 3.
For the record, as the person who introduced the source transformer,
it brings me joy to delete it. It accomplished its goal to facilitate
a port to Python 3 without overly burdening people on some painful
low-level differences between Python 2 and 3. It is unfortunate we
still have to wallpaper over many differences with the pycompat
shim. But it is what it is.
Differential Revision: https://phab.mercurial-scm.org/D7015
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Mon, 07 Oct 2019 00:04:04 -0400 |
parents | 687b865b95ad |
children | 9f70512ae2cf |
comparison
equal
deleted
inserted
replaced
43105:649d3ac37a12 | 43106:d783f945a701 |
---|---|
353 del self._filegenerators[genid] | 353 del self._filegenerators[genid] |
354 | 354 |
355 def _generatefiles(self, suffix=b'', group=gengroupall): | 355 def _generatefiles(self, suffix=b'', group=gengroupall): |
356 # write files registered for generation | 356 # write files registered for generation |
357 any = False | 357 any = False |
358 for id, entry in sorted(self._filegenerators.iteritems()): | 358 for id, entry in sorted(pycompat.iteritems(self._filegenerators)): |
359 any = True | 359 any = True |
360 order, filenames, genfunc, location = entry | 360 order, filenames, genfunc, location = entry |
361 | 361 |
362 # for generation at closing, check if it's before or after finalize | 362 # for generation at closing, check if it's before or after finalize |
363 postfinalize = group == gengrouppostfinalize | 363 postfinalize = group == gengrouppostfinalize |