comparison hgext/githelp.py @ 38118:d8bd6a9c64a5

githelp: fail gracefully in a couple cases where arguments are missing

I didn't bother adding tests because the other commands that already handled
missing arguments don't test these edge cases.  I didn't read over all of the
code, rather I scanned for `args` not being checked before indexing.

38117:69ec6f98cfa6

                old = args.pop(0)
            else:
                # shell command to output the active bookmark for the active
                # revision
                old = '`hg log -T"{activebookmark}" -r .`'
        new = args[0]
        cmd['-m'] = old
        cmd.append(new)
    else:
        if len(args) > 1:

        cmd['-i'] = None

    ui.status((bytes(cmd)), "\n")

def svn(ui, repo, *args, **kwargs):
    svncmd = args[0]
    if not svncmd in gitsvncommands:
        ui.warn(_("error: unknown git svn command %s\n") % (svncmd))

    args = args[1:]

def svnfindrev(ui, repo, *args, **kwargs):
    cmdoptions = [
    ]
    args, opts = parseoptions(ui, cmdoptions, args)

    cmd = Command('log')
    cmd['-r'] = args[0]

    ui.status((bytes(cmd)), "\n")

    if opts.get('list'):
        cmd = Command('tags')
    else:
        cmd = Command('tag')
        cmd.append(args[0])
        if len(args) > 1:
            cmd['-r'] = args[1]

        if opts.get('delete'):

38118:d8bd6a9c64a5

                old = args.pop(0)
            else:
                # shell command to output the active bookmark for the active
                # revision
                old = '`hg log -T"{activebookmark}" -r .`'
        else:
            raise error.Abort(_('missing newbranch argument'))
        new = args[0]
        cmd['-m'] = old
        cmd.append(new)
    else:
        if len(args) > 1:

        cmd['-i'] = None

    ui.status((bytes(cmd)), "\n")

def svn(ui, repo, *args, **kwargs):
    if not args:
        raise error.Abort(_('missing svn command'))
    svncmd = args[0]
    if not svncmd in gitsvncommands:
        ui.warn(_("error: unknown git svn command %s\n") % (svncmd))

    args = args[1:]

def svnfindrev(ui, repo, *args, **kwargs):
    cmdoptions = [
    ]
    args, opts = parseoptions(ui, cmdoptions, args)

    if not args:
        raise error.Abort(_('missing find-rev argument'))

    cmd = Command('log')
    cmd['-r'] = args[0]

    ui.status((bytes(cmd)), "\n")

    if opts.get('list'):
        cmd = Command('tags')
    else:
        cmd = Command('tag')

        if not args:
            raise error.Abort(_('missing tag argument'))

        cmd.append(args[0])
        if len(args) > 1:
            cmd['-r'] = args[1]

        if opts.get('delete'):