comparison mercurial/dispatch.py @ 35030:d9aba3730d30 stable

dispatch: abort if early boolean options can't be parsed

Perhaps we'll need to restrict the parsing rules of --debugger and --profile,
where this patch will help us know why the --debugger option doesn't work.

I have another series to extend this feature to --config/--cwd/-R, but even
with that, shell aliases can be used to get around the restriction.

35029:e16f68c4abe3

        # input/output/error streams
        self.fin = fin
        self.fout = fout
        self.ferr = ferr

        # reposetups which run before extensions, useful for chg to pre-fill
        # low-level repo state (for example, changelog) before extensions.
        self.prereposetups = prereposetups or []

    >>> _earlyreqoptbool(req, b'debugger', [b'--debugger'])
    True

    >>> req = request([b'x', b'--', b'--debugger'])
    >>> _earlyreqoptbool(req, b'debugger', [b'--debugger'])
    False
    """
    try:
        argcount = req.args.index("--")
    except ValueError:
        argcount = len(req.args)
    value = False
    pos = 0
    while pos < argcount:
        arg = req.args[pos]
        if arg in aliases:
            value = True
        pos += 1
    return value

def runcommand(lui, repo, cmd, fullargs, ui, options, d, cmdpats, cmdoptions):
    # run pre-hook, and abort if it fails
    hook.hook(lui, repo, "pre-%s" % cmd, True, args=" ".join(fullargs),

            raise error.Abort(_("option --cwd may not be abbreviated!"))
        if options["repository"]:
            raise error.Abort(_(
                "option -R has to be separated from other options (e.g. not "
                "-qR) and --repository may only be abbreviated as --repo!"))

        if options["encoding"]:
            encoding.encoding = options["encoding"]
        if options["encodingmode"]:
            encoding.encodingmode = options["encodingmode"]

35030:d9aba3730d30

        # input/output/error streams
        self.fin = fin
        self.fout = fout
        self.ferr = ferr

        # remember options pre-parsed by _earlyreqopt*()
        self.earlyoptions = {}

        # reposetups which run before extensions, useful for chg to pre-fill
        # low-level repo state (for example, changelog) before extensions.
        self.prereposetups = prereposetups or []

    >>> _earlyreqoptbool(req, b'debugger', [b'--debugger'])
    True

    >>> req = request([b'x', b'--', b'--debugger'])
    >>> _earlyreqoptbool(req, b'debugger', [b'--debugger'])
    """
    try:
        argcount = req.args.index("--")
    except ValueError:
        argcount = len(req.args)
    value = None
    pos = 0
    while pos < argcount:
        arg = req.args[pos]
        if arg in aliases:
            value = True
        pos += 1
    req.earlyoptions[name] = value
    return value

def runcommand(lui, repo, cmd, fullargs, ui, options, d, cmdpats, cmdoptions):
    # run pre-hook, and abort if it fails
    hook.hook(lui, repo, "pre-%s" % cmd, True, args=" ".join(fullargs),

            raise error.Abort(_("option --cwd may not be abbreviated!"))
        if options["repository"]:
            raise error.Abort(_(
                "option -R has to be separated from other options (e.g. not "
                "-qR) and --repository may only be abbreviated as --repo!"))
        if options["debugger"] != req.earlyoptions["debugger"]:
            raise error.Abort(_("option --debugger may not be abbreviated!"))
        # don't validate --profile/--traceback, which can be enabled from now

        if options["encoding"]:
            encoding.encoding = options["encoding"]
        if options["encodingmode"]:
            encoding.encodingmode = options["encodingmode"]