comparison tests/test-http.t @ 51181:dcaa2df1f688

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Mon, 11 Dec 2023 22:27:59 +0100
parents 2cf264e9aa75
children
comparison
equal deleted inserted replaced
51180:2e0b2a387502 51181:dcaa2df1f688
27 clone via stream 27 clone via stream
28 28
29 #if no-reposimplestore 29 #if no-reposimplestore
30 $ hg clone --stream http://localhost:$HGPORT/ copy 2>&1 30 $ hg clone --stream http://localhost:$HGPORT/ copy 2>&1
31 streaming all changes 31 streaming all changes
32 9 files to transfer, 715 bytes of data (no-zstd !) 32 10 files to transfer, 715 bytes of data (no-zstd !)
33 9 files to transfer, 717 bytes of data (zstd !) 33 10 files to transfer, 717 bytes of data (zstd no-rust !)
34 12 files to transfer, 843 bytes of data (zstd rust !)
34 transferred * bytes in * seconds (*/sec) (glob) 35 transferred * bytes in * seconds (*/sec) (glob)
35 updating to branch default 36 updating to branch default
36 4 files updated, 0 files merged, 0 files removed, 0 files unresolved 37 4 files updated, 0 files merged, 0 files removed, 0 files unresolved
37 $ hg verify -R copy -q 38 $ hg verify -R copy -q
38 #endif 39 #endif
252 5fed3813f7f5 253 5fed3813f7f5
253 254
254 #if no-reposimplestore 255 #if no-reposimplestore
255 $ hg clone http://user:pass@localhost:$HGPORT2/ dest 2>&1 256 $ hg clone http://user:pass@localhost:$HGPORT2/ dest 2>&1
256 streaming all changes 257 streaming all changes
257 10 files to transfer, 1.01 KB of data 258 11 files to transfer, 1.01 KB of data (no-rust !)
259 13 files to transfer, 1.13 KB of data (rust !)
258 transferred * KB in * seconds (*/sec) (glob) 260 transferred * KB in * seconds (*/sec) (glob)
259 updating to branch default 261 updating to branch default
260 5 files updated, 0 files merged, 0 files removed, 0 files unresolved 262 5 files updated, 0 files merged, 0 files removed, 0 files unresolved
261 #endif 263 #endif
262 264