comparison tests/test-remotefilelog-clone-tree.t @ 51181:dcaa2df1f688

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Mon, 11 Dec 2023 22:27:59 +0100
parents 7ee07e1a25c0
children
comparison
equal deleted inserted replaced
51180:2e0b2a387502 51181:dcaa2df1f688
18 18
19 # shallow clone from full 19 # shallow clone from full
20 20
21 $ hgcloneshallow ssh://user@dummy/master shallow --noupdate 21 $ hgcloneshallow ssh://user@dummy/master shallow --noupdate
22 streaming all changes 22 streaming all changes
23 4 files to transfer, 449 bytes of data 23 5 files to transfer, 449 bytes of data (no-rust !)
24 transferred 449 bytes in * seconds (*/sec) (glob) 24 transferred 449 bytes in * seconds (*/sec) (glob) (no-rust !)
25 7 files to transfer, 575 bytes of data (rust !)
26 transferred 575 bytes in *.* seconds (*) (glob) (rust !)
25 searching for changes 27 searching for changes
26 no changes found 28 no changes found
27 $ cd shallow 29 $ cd shallow
28 $ hg debugrequires 30 $ hg debugrequires
29 dotencode 31 dotencode
63 65
64 # shallow clone from shallow 66 # shallow clone from shallow
65 67
66 $ hgcloneshallow ssh://user@dummy/shallow shallow2 --noupdate 68 $ hgcloneshallow ssh://user@dummy/shallow shallow2 --noupdate
67 streaming all changes 69 streaming all changes
68 5 files to transfer, 1008 bytes of data 70 6 files to transfer, 1008 bytes of data (no-rust !)
69 transferred 1008 bytes in * seconds (*/sec) (glob) 71 transferred 1008 bytes in * seconds (*/sec) (glob) (no-rust !)
72 8 files to transfer, 1.11 KB of data (rust !)
73 transferred 1.11 KB in * seconds (* */sec) (glob) (rust !)
70 searching for changes 74 searching for changes
71 no changes found 75 no changes found
72 $ cd shallow2 76 $ cd shallow2
73 $ hg debugrequires 77 $ hg debugrequires
74 dotencode 78 dotencode