comparison tests/test-remotefilelog-partial-shallow.t @ 51181:dcaa2df1f688

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Mon, 11 Dec 2023 22:27:59 +0100
parents 84a93fa7ecfd
children
comparison
equal deleted inserted replaced
51180:2e0b2a387502 51181:dcaa2df1f688
16 16
17 # partial shallow clone 17 # partial shallow clone
18 18
19 $ hg clone --shallow ssh://user@dummy/master shallow --noupdate --config remotefilelog.includepattern=foo 19 $ hg clone --shallow ssh://user@dummy/master shallow --noupdate --config remotefilelog.includepattern=foo
20 streaming all changes 20 streaming all changes
21 3 files to transfer, 336 bytes of data (no-zstd !) 21 4 files to transfer, 336 bytes of data (no-zstd !)
22 transferred 336 bytes in * seconds (* */sec) (glob) (no-zstd !) 22 transferred 336 bytes in * seconds (* */sec) (glob) (no-zstd !)
23 3 files to transfer, 338 bytes of data (zstd !) 23 4 files to transfer, 338 bytes of data (zstd no-rust !)
24 transferred 338 bytes in * seconds (* */sec) (glob) (zstd !) 24 transferred 338 bytes in * seconds (* */sec) (glob) (zstd no-rust !)
25 6 files to transfer, 464 bytes of data (zstd rust !)
26 transferred 464 bytes in * seconds (*/sec) (glob) (zstd rust !)
25 searching for changes 27 searching for changes
26 no changes found 28 no changes found
27 $ cat >> shallow/.hg/hgrc <<EOF 29 $ cat >> shallow/.hg/hgrc <<EOF
28 > [remotefilelog] 30 > [remotefilelog]
29 > cachepath=$PWD/hgcache 31 > cachepath=$PWD/hgcache