comparison tests/test-ssh.t @ 51181:dcaa2df1f688

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Mon, 11 Dec 2023 22:27:59 +0100
parents 02eae2df911a
children 2e8a88e5809f
comparison
equal deleted inserted replaced
51180:2e0b2a387502 51181:dcaa2df1f688
52 52
53 #if no-reposimplestore 53 #if no-reposimplestore
54 54
55 $ hg clone --stream ssh://user@dummy/remote local-stream 55 $ hg clone --stream ssh://user@dummy/remote local-stream
56 streaming all changes 56 streaming all changes
57 8 files to transfer, 827 bytes of data (no-zstd !) 57 9 files to transfer, 827 bytes of data (no-zstd !)
58 transferred 827 bytes in * seconds (*) (glob) (no-zstd !) 58 transferred 827 bytes in * seconds (*) (glob) (no-zstd !)
59 8 files to transfer, 846 bytes of data (zstd !) 59 9 files to transfer, 846 bytes of data (zstd no-rust !)
60 11 files to transfer, 972 bytes of data (zstd rust !)
60 transferred * bytes in * seconds (* */sec) (glob) (zstd !) 61 transferred * bytes in * seconds (* */sec) (glob) (zstd !)
61 updating to branch default 62 updating to branch default
62 2 files updated, 0 files merged, 0 files removed, 0 files unresolved 63 2 files updated, 0 files merged, 0 files removed, 0 files unresolved
63 $ cd local-stream 64 $ cd local-stream
64 $ hg verify -q 65 $ hg verify -q
69 clone bookmarks via stream 70 clone bookmarks via stream
70 71
71 $ hg -R local-stream book mybook 72 $ hg -R local-stream book mybook
72 $ hg clone --stream ssh://user@dummy/local-stream stream2 73 $ hg clone --stream ssh://user@dummy/local-stream stream2
73 streaming all changes 74 streaming all changes
74 15 files to transfer, * of data (glob) 75 16 files to transfer, * of data (glob) (no-rust !)
76 18 files to transfer, * of data (glob) (rust !)
75 transferred * in * seconds (*) (glob) 77 transferred * in * seconds (*) (glob)
76 updating to branch default 78 updating to branch default
77 2 files updated, 0 files merged, 0 files removed, 0 files unresolved 79 2 files updated, 0 files merged, 0 files removed, 0 files unresolved
78 $ cd stream2 80 $ cd stream2
79 $ hg book 81 $ hg book