comparison tests/test-static-http.t @ 51181:dcaa2df1f688

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Mon, 11 Dec 2023 22:27:59 +0100
parents 758e40b9a8af
children
comparison
equal deleted inserted replaced
51180:2e0b2a387502 51181:dcaa2df1f688
223 /.hg/bookmarks 223 /.hg/bookmarks
224 /.hg/bookmarks.current 224 /.hg/bookmarks.current
225 /.hg/cache/hgtagsfnodes1 225 /.hg/cache/hgtagsfnodes1
226 /.hg/dirstate 226 /.hg/dirstate
227 /.hg/requires 227 /.hg/requires
228 /.hg/store/00changelog.d
228 /.hg/store/00changelog.i 229 /.hg/store/00changelog.i
229 /.hg/store/00manifest.i 230 /.hg/store/00manifest.i
230 /.hg/store/data/%7E2ehgsub.i (no-py37 !) 231 /.hg/store/data/%7E2ehgsub.i (no-py37 !)
231 /.hg/store/data/%7E2ehgsubstate.i (no-py37 !) 232 /.hg/store/data/%7E2ehgsubstate.i (no-py37 !)
232 /.hg/store/data/a.i 233 /.hg/store/data/a.i
250 /remote-with-names/.hg/cache/hgtagsfnodes1 251 /remote-with-names/.hg/cache/hgtagsfnodes1
251 /remote-with-names/.hg/cache/tags2-served 252 /remote-with-names/.hg/cache/tags2-served
252 /remote-with-names/.hg/dirstate 253 /remote-with-names/.hg/dirstate
253 /remote-with-names/.hg/localtags 254 /remote-with-names/.hg/localtags
254 /remote-with-names/.hg/requires 255 /remote-with-names/.hg/requires
256 /remote-with-names/.hg/store/00changelog.d
255 /remote-with-names/.hg/store/00changelog.i 257 /remote-with-names/.hg/store/00changelog.i
256 /remote-with-names/.hg/store/00manifest.i 258 /remote-with-names/.hg/store/00manifest.i
257 /remote-with-names/.hg/store/data/%7E2ehgtags.i (no-py37 !) 259 /remote-with-names/.hg/store/data/%7E2ehgtags.i (no-py37 !)
258 /remote-with-names/.hg/store/data/foo.i 260 /remote-with-names/.hg/store/data/foo.i
259 /remote-with-names/.hg/store/data/~2ehgtags.i (py37 !) 261 /remote-with-names/.hg/store/data/~2ehgtags.i (py37 !)
268 /remote/.hg/cache/rbc-names-v1 270 /remote/.hg/cache/rbc-names-v1
269 /remote/.hg/cache/tags2-served 271 /remote/.hg/cache/tags2-served
270 /remote/.hg/dirstate 272 /remote/.hg/dirstate
271 /remote/.hg/localtags 273 /remote/.hg/localtags
272 /remote/.hg/requires 274 /remote/.hg/requires
275 /remote/.hg/store/00changelog.d
273 /remote/.hg/store/00changelog.i 276 /remote/.hg/store/00changelog.i
274 /remote/.hg/store/00manifest.i 277 /remote/.hg/store/00manifest.i
275 /remote/.hg/store/data/%7E2edotfile%20with%20spaces.i (no-py37 !) 278 /remote/.hg/store/data/%7E2edotfile%20with%20spaces.i (no-py37 !)
276 /remote/.hg/store/data/%7E2ehgtags.i (no-py37 !) 279 /remote/.hg/store/data/%7E2ehgtags.i (no-py37 !)
277 /remote/.hg/store/data/bar.i 280 /remote/.hg/store/data/bar.i
290 /sub/.hg/bookmarks 293 /sub/.hg/bookmarks
291 /sub/.hg/bookmarks.current 294 /sub/.hg/bookmarks.current
292 /sub/.hg/cache/hgtagsfnodes1 295 /sub/.hg/cache/hgtagsfnodes1
293 /sub/.hg/dirstate 296 /sub/.hg/dirstate
294 /sub/.hg/requires 297 /sub/.hg/requires
298 /sub/.hg/store/00changelog.d
295 /sub/.hg/store/00changelog.i 299 /sub/.hg/store/00changelog.i
296 /sub/.hg/store/00manifest.i 300 /sub/.hg/store/00manifest.i
297 /sub/.hg/store/data/%7E2ehgtags.i (no-py37 !) 301 /sub/.hg/store/data/%7E2ehgtags.i (no-py37 !)
298 /sub/.hg/store/data/test.i 302 /sub/.hg/store/data/test.i
299 /sub/.hg/store/data/~2ehgtags.i (py37 !) 303 /sub/.hg/store/data/~2ehgtags.i (py37 !)