comparison contrib/check-code.py @ 26777:df1a29ec45bf

check-code: block non-portable pipe-and
author timeless <timeless@mozdev.org>
date Thu, 15 Oct 2015 20:36:12 -0400
parents b3f7516fa50e
children b81b8dbecc26
comparison
equal deleted inserted replaced
26776:f69c79395fb7 26777:df1a29ec45bf
123 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)', 123 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
124 "put a backslash-escaped newline after sed 'i' command"), 124 "put a backslash-escaped newline after sed 'i' command"),
125 (r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"), 125 (r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"),
126 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"), 126 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
127 (r'\butil\.Abort\b', "directly use error.Abort"), 127 (r'\butil\.Abort\b', "directly use error.Abort"),
128 (r'\|&', "don't use |&, use 2>&1"),
128 ], 129 ],
129 # warnings 130 # warnings
130 [ 131 [
131 (r'^function', "don't use 'function', use old style"), 132 (r'^function', "don't use 'function', use old style"),
132 (r'^diff.*-\w*N', "don't use 'diff -N'"), 133 (r'^diff.*-\w*N', "don't use 'diff -N'"),