Mercurial > hg
comparison contrib/check-code.py @ 48870:df56e6bd37f6
py3: use pickle directly
pycompat.pickle abstracted over the different pickle modules in
Python 2 and 3. Now that we're Python 3 only, it is safe to use the
`pickle` module directly. So this commit does that.
As part of this we remove the rules from check-code.py that were
forbidden direct pickle module use.
We retain the `util.pickle` symbol for backwards compatibility, just
in case some extensions were using it.
Differential Revision: https://phab.mercurial-scm.org/D12249
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 01 Mar 2022 20:29:03 -0800 |
parents | b84fe613de33 |
children | 6000f5b25c9b |
comparison
equal
deleted
inserted
replaced
48869:57b58413dad1 | 48870:df56e6bd37f6 |
---|---|
444 r'^import SocketServer', | 444 r'^import SocketServer', |
445 "don't use SockerServer, use util.socketserver", | 445 "don't use SockerServer, use util.socketserver", |
446 ), | 446 ), |
447 (r'^import urlparse', "don't use urlparse, use util.urlreq"), | 447 (r'^import urlparse', "don't use urlparse, use util.urlreq"), |
448 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), | 448 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), |
449 (r'^import cPickle', "don't use cPickle, use util.pickle"), | |
450 (r'^import pickle', "don't use pickle, use util.pickle"), | |
451 (r'^import httplib', "don't use httplib, use util.httplib"), | 449 (r'^import httplib', "don't use httplib, use util.httplib"), |
452 (r'^import BaseHTTPServer', "use util.httpserver instead"), | 450 (r'^import BaseHTTPServer', "use util.httpserver instead"), |
453 ( | 451 ( |
454 r'^(from|import) mercurial\.(cext|pure|cffi)', | 452 r'^(from|import) mercurial\.(cext|pure|cffi)', |
455 "use mercurial.policy.importmod instead", | 453 "use mercurial.policy.importmod instead", |