comparison mercurial/localrepo.py @ 15321:e174353e8cda stable

subrepos: abort commit by default if a subrepo is dirty (BC)

This changeset flips the default value of ui.commitsubrepos setting
from True to False and adds a --subrepos flag to commit.

The commit, status, and diff commands behave like this with regard to
recusion and the ui.commitsubrepos setting:

          | recurses      | recurses
          | by default    | with --subrepos
  --------+---------------+----------------
  commit: | commitsubrepo | True
  status: | False         | True
  diff:   | False         | True

By changing the default from True to False, the table becomes
consistent in the two columns:

* without --subrepos on the command line, commit will abort if a
  subrepo is dirty and status/diff wont show changes inside subrepos.

* with --subrepos, all three commands will recurse.

A --subrepos flag on the command line overrides the config settin.g

15320:681267a5f491

                # clean up .hgsubstate when .hgsub is removed
                if ('.hgsubstate' in wctx and
                    '.hgsubstate' not in changes[0] + changes[1] + changes[2]):
                    changes[2].insert(0, '.hgsubstate')

            if subs and not self.ui.configbool('ui', 'commitsubrepos', True):
                changedsubs = [s for s in subs if wctx.sub(s).dirty(True)]
                if changedsubs:
                    raise util.Abort(_("uncommitted changes in subrepo %s")
                                     % changedsubs[0])

            # make sure all explicit patterns are matched
            if not force and match.files():
                matched = set(changes[0] + changes[1] + changes[2])

15321:e174353e8cda

                # clean up .hgsubstate when .hgsub is removed
                if ('.hgsubstate' in wctx and
                    '.hgsubstate' not in changes[0] + changes[1] + changes[2]):
                    changes[2].insert(0, '.hgsubstate')

            if subs and not self.ui.configbool('ui', 'commitsubrepos', False):
                changedsubs = [s for s in subs if wctx.sub(s).dirty(True)]
                if changedsubs:
                    raise util.Abort(_("uncommitted changes in subrepo %s")
                                     % changedsubs[0],
                                     hint=_("use --subrepos for recursive commit"))

            # make sure all explicit patterns are matched
            if not force and match.files():
                matched = set(changes[0] + changes[1] + changes[2])