comparison mercurial/dispatch.py @ 29784:e3501546f7e4

profiling: add a context manager that no-ops if profiling isn't enabled

And refactor dispatch.py to use it. As you can see, the resulting code
is much simpler.

I was tempted to inline _runcommand as part of writing this series.
However, a number of extensions wrap _runcommand. So keeping it around
is necessary (extensions can't easily wrap runcommand because it calls
hooks before and after command execution).

29783:5d44197c208b

    finally:
        if repo and repo != req.repo:
            repo.close()

def _runcommand(ui, options, cmd, cmdfunc):
    """Enables the profiler if applicable.

    ``profiling.enabled`` - boolean config that enables or disables profiling
    """
    def checkargs():
        try:
            return cmdfunc()
        except error.SignatureError:
            raise error.CommandError(cmd, _("invalid arguments"))

    if ui.configbool('profiling', 'enabled'):
        with profiling.profile(ui):
            return checkargs()
    else:
        return checkargs()

def _exceptionwarning(ui):
    """Produce a warning message for the current active exception"""

    # For compatibility checking, we discard the portion of the hg

29784:e3501546f7e4

    finally:
        if repo and repo != req.repo:
            repo.close()

def _runcommand(ui, options, cmd, cmdfunc):
    """Run a command function, possibly with profiling enabled."""
    with profiling.maybeprofile(ui):
        try:
            return cmdfunc()
        except error.SignatureError:
            raise error.CommandError(cmd, _('invalid arguments'))

def _exceptionwarning(ui):
    """Produce a warning message for the current active exception"""

    # For compatibility checking, we discard the portion of the hg