comparison mercurial/exchange.py @ 28667:e7bf227e33a5

exchange: get rid of "getcgkwargs" variable

This also makes the "version" argument explicit (never relies on
getlocalchangegroupraw()'s default), which I think is a good thing.

28666:ae53ecc47414

                              b2caps=None, heads=None, common=None, **kwargs):
    """add a changegroup part to the requested bundle"""
    cg = None
    if kwargs.get('cg', True):
        # build changegroup bundle here.
        version = None
        cgversions = b2caps.get('changegroup')
        getcgkwargs = {}
        if cgversions:  # 3.1 and 3.2 ship with an empty value
            cgversions = [v for v in cgversions
                          if v in changegroup.supportedoutgoingversions(repo)]
            if not cgversions:
                raise ValueError(_('no common changegroup version'))
            version = getcgkwargs['version'] = max(cgversions)
        outgoing = changegroup.computeoutgoing(repo, heads, common)
        cg = changegroup.getlocalchangegroupraw(repo, source, outgoing,
                                                bundlecaps=bundlecaps,
                                                **getcgkwargs)

    if cg:
        part = bundler.newpart('changegroup', data=cg)
        if version is not None:
            part.addparam('version', version)
        part.addparam('nbchanges', str(len(outgoing.missing)), mandatory=False)
        if 'treemanifest' in repo.requirements:
            part.addparam('treemanifest', '1')

28667:e7bf227e33a5

                              b2caps=None, heads=None, common=None, **kwargs):
    """add a changegroup part to the requested bundle"""
    cg = None
    if kwargs.get('cg', True):
        # build changegroup bundle here.
        version = '01'
        cgversions = b2caps.get('changegroup')
        if cgversions:  # 3.1 and 3.2 ship with an empty value
            cgversions = [v for v in cgversions
                          if v in changegroup.supportedoutgoingversions(repo)]
            if not cgversions:
                raise ValueError(_('no common changegroup version'))
            version = max(cgversions)
        outgoing = changegroup.computeoutgoing(repo, heads, common)
        cg = changegroup.getlocalchangegroupraw(repo, source, outgoing,
                                                bundlecaps=bundlecaps,
                                                version=version)

    if cg:
        part = bundler.newpart('changegroup', data=cg)
        if cgversions:
            part.addparam('version', version)
        part.addparam('nbchanges', str(len(outgoing.missing)), mandatory=False)
        if 'treemanifest' in repo.requirements:
            part.addparam('treemanifest', '1')