comparison rust/hg-core/src/utils.rs @ 49930:e98fd81bb151

rust-clippy: fix most warnings in `hg-core`

All of these are simple changes that for the most part are clear improvements
and the rest are at most equivalent.

The remaining warnings have to be fixed either with a bigger refactor like for
the nested "revlog" module, or in the dependency `bytes-cast`, which we own.

This will be done sometime in the future.

49929:5f1cd6839c69

        let b = iter.next()?;
        Some((a, b))
    }

    fn split_2_by_slice(&self, separator: &[u8]) -> Option<(&[u8], &[u8])> {
        if let Some(pos) = find_slice_in_slice(self, separator) {
            Some((&self[..pos], &self[pos + separator.len()..]))
        } else {
            None
        }
    }
}

pub trait Escaped {
    /// Return bytes escaped for display to the user

            Some(left_value) => match merge(&key, left_value, &right_value) {
                MergeResult::LeftValue => {}
                MergeResult::RightValue => {
                    left.insert(key, right_value);
                }
                MergeResult::UseNewValue(new_value) => {
                    left.insert(key, new_value);
                }
            },
        }
    }

49930:e98fd81bb151

        let b = iter.next()?;
        Some((a, b))
    }

    fn split_2_by_slice(&self, separator: &[u8]) -> Option<(&[u8], &[u8])> {
        find_slice_in_slice(self, separator)
            .map(|pos| (&self[..pos], &self[pos + separator.len()..]))
    }
}

pub trait Escaped {
    /// Return bytes escaped for display to the user

            Some(left_value) => match merge(&key, left_value, &right_value) {
                MergeResult::LeftValue => {}
                MergeResult::RightValue => {
                    left.insert(key, right_value);
                }
                MergeResult::NewValue(new_value) => {
                    left.insert(key, new_value);
                }
            },
        }
    }