comparison tests/run-tests.py @ 49214:eca367970253 stable

run-tests: send the test result after freeing the channel

Sending the message about the test being "done" signals to the main thread that
a new test can be started.  Before this changeset, we sent this signal before
freeing the channel, there is room for a race condition where a new test would
search for a channel before the old test freed the one it used.

This is an example of the failure it would produce:

    https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/552404

49213:c95e5ba4de1e

                    channel = n
                    break
            else:
                raise ValueError('Could not find output channel')
            channels[channel] = "=" + test.name[5:].split(".")[0]
            try:
                test(result)
                done.put(None)
            except KeyboardInterrupt:
                done.put(None)
            except:  # re-raises
                done.put(('!', test, 'run-test raised an error, see traceback'))
                raise
            finally:
                try:
                    channels[channel] = ''
                except IndexError:
                    pass

        def stat():
            count = 0
            while channels:
                d = '\n%03s  ' % count

49214:eca367970253

                    channel = n
                    break
            else:
                raise ValueError('Could not find output channel')
            channels[channel] = "=" + test.name[5:].split(".")[0]

            r = None
            try:
                test(result)
            except KeyboardInterrupt:
                pass
            except:  # re-raises
                r = ('!', test, 'run-test raised an error, see traceback')
                raise
            finally:
                try:
                    channels[channel] = ''
                except IndexError:
                    pass
                done.put(r)

        def stat():
            count = 0
            while channels:
                d = '\n%03s  ' % count