comparison hgext/histedit.py @ 28216:eed7d8c07c20

histedit: make histedit aware of obsolescense not stored in state (issue4800)

Before this change, when histedit exited to interactive session (during edit
command for example), user could introduce obsolescence markers that would not
be known to histedit. For example, user could've amended one of the commits.
The fact of this amendment would not be stored in histedit's state file
and later, when histedit would try to process all the replacements,
one of the final successors (in histedit's opinion) would turn out to be hidden.
This behavior is described in issue4800. This commit fixes it.

28215:f7c5c7847b53

        raise error.ParseError(_('missing rules for changeset %s') %
                missing[0][:12],
                hint=_('use "drop %s" to discard, see also: '
                       '"hg help -e histedit.config"') % missing[0][:12])

def processreplacement(state):
    """process the list of replacements to return

    1) the final mapping between original and created nodes
    2) the list of temporary node created by histedit
    3) the list of new commit created by histedit"""
    replacements = state.replacements
    allsuccs = set()
    replaced = set()
    fullmapping = {}
    # initialize basic set
    # fullmapping records all operations recorded in replacement

28216:eed7d8c07c20

        raise error.ParseError(_('missing rules for changeset %s') %
                missing[0][:12],
                hint=_('use "drop %s" to discard, see also: '
                       '"hg help -e histedit.config"') % missing[0][:12])

def adjustreplacementsfrommarkers(repo, oldreplacements):
    """Adjust replacements from obsolescense markers

    Replacements structure is originally generated based on
    histedit's state and does not account for changes that are
    not recorded there. This function fixes that by adding
    data read from obsolescense markers"""
    if not obsolete.isenabled(repo, obsolete.createmarkersopt):
        return oldreplacements

    unfi = repo.unfiltered()
    newreplacements = list(oldreplacements)
    oldsuccs = [r[1] for r in oldreplacements]
    # successors that have already been added to succstocheck once
    seensuccs = set().union(*oldsuccs) # create a set from an iterable of tuples
    succstocheck = list(seensuccs)
    while succstocheck:
        n = succstocheck.pop()
        try:
            ctx = unfi[n]
        except error.RepoError:
            # XXX node unknown locally, we should properly follow marker
            newreplacements.append((n, ()))
            continue

        for marker in obsolete.successormarkers(ctx):
            nsuccs = marker.succnodes()
            newreplacements.append((n, nsuccs))
            for nsucc in nsuccs:
                if nsucc not in seensuccs:
                    seensuccs.add(nsucc)
                    succstocheck.append(nsucc)

    return newreplacements

def processreplacement(state):
    """process the list of replacements to return

    1) the final mapping between original and created nodes
    2) the list of temporary node created by histedit
    3) the list of new commit created by histedit"""
    replacements = adjustreplacementsfrommarkers(state.repo, state.replacements)
    allsuccs = set()
    replaced = set()
    fullmapping = {}
    # initialize basic set
    # fullmapping records all operations recorded in replacement