Mercurial > hg
comparison mercurial/obsolete.py @ 48789:ef50a62eec40
obsolete: don't use os.stat in repo.obsstore.__nonzero__ if it's static HTTP
If a repo is accessed via static HTTP, then we obviously can't use os.stat() to
just peek at the file size. Let's download the entire file to check its size.
Yes, this feels wasteful, but:
1. If we're cloning or pulling a repo from a static HTTP server, we need the
contents of the obsstore anyway.
2. Implementing statichttpvfs.stat() that uses HEAD will result in one more
request to a static-only HTTP server, which is already slow. Also parsing a
response to a HEAD request to construct os.stat_result is pretty hacky.
There's also a question of the remote server properly supporting HEAD method
and reporting at least file size.
3. Implementing statichttpvfs.stat() that uses GET is pretty much the same
thing as we do here, except we can't even cache the response easily, unlike
simply accessing obsstore._data, which is @propertycache'd.
Importing statichttprepo locally to avoid circular import.
See also: 4507bc001365 and commit message of f8f2ecdde4b5.
Differential Revision: https://phab.mercurial-scm.org/D12195
author | Anton Shestakov <av6@dwimlabs.net> |
---|---|
date | Mon, 31 Jan 2022 18:13:00 +0300 |
parents | 27fe84a8dd60 |
children | 6000f5b25c9b |
comparison
equal
deleted
inserted
replaced
48788:f90337706ce7 | 48789:ef50a62eec40 |
---|---|
573 | 573 |
574 def __len__(self): | 574 def __len__(self): |
575 return len(self._all) | 575 return len(self._all) |
576 | 576 |
577 def __nonzero__(self): | 577 def __nonzero__(self): |
578 from . import statichttprepo | |
579 | |
580 if isinstance(self.repo, statichttprepo.statichttprepository): | |
581 # If repo is accessed via static HTTP, then we can't use os.stat() | |
582 # to just peek at the file size. | |
583 return len(self._data) > 1 | |
578 if not self._cached('_all'): | 584 if not self._cached('_all'): |
579 try: | 585 try: |
580 return self.svfs.stat(b'obsstore').st_size > 1 | 586 return self.svfs.stat(b'obsstore').st_size > 1 |
581 except OSError as inst: | 587 except OSError as inst: |
582 if inst.errno not in (errno.ENOENT, errno.EINVAL): | 588 if inst.errno != errno.ENOENT: |
583 raise | 589 raise |
584 # just build an empty _all list if no obsstore exists, which | 590 # just build an empty _all list if no obsstore exists, which |
585 # avoids further stat() syscalls | 591 # avoids further stat() syscalls |
586 return bool(self._all) | 592 return bool(self._all) |
587 | 593 |