comparison mercurial/cmdutil.py @ 22213:f1debbcd71cd

revert: add an XXX about rename tracking

We check for rename information in the dirstate. This is probably not enough to
preserve this behavior when using an explicit target rev.

I just spotted this while working on this code, but this is outside the scope
of my series so I'm just adding a comment to highlight this suspicious
situation.

22212:f18aca03ddd9

        # if f is a rename, update `names` to also revert the source
        cwd = repo.getcwd()
        for f in dsadded:
            src = repo.dirstate.copied(f)
            if src and src not in names and repo.dirstate[src] == 'r':
                dsremoved.add(src)
                names[src] = (repo.pathto(src, cwd), True)

        ## computation of the action to performs on `names` content.

22213:f1debbcd71cd

        # if f is a rename, update `names` to also revert the source
        cwd = repo.getcwd()
        for f in dsadded:
            src = repo.dirstate.copied(f)
            # XXX should we check for rename down to target node?
            if src and src not in names and repo.dirstate[src] == 'r':
                dsremoved.add(src)
                names[src] = (repo.pathto(src, cwd), True)

        ## computation of the action to performs on `names` content.