comparison mercurial/transaction.py @ 44407:f6798c1a80fa

transaction: clarify the logic around pre-finalize/post-finalize

I am taking a bit more verbose route, but I find it easier to follow for people
who (re)discover the code.

(This is a gratuitous cleanup I did while looking at something else.)

Differential Revision: https://phab.mercurial-scm.org/D8176

44406:baf8c3f944eb

            del self._filegenerators[genid]

    def _generatefiles(self, suffix=b'', group=GEN_GROUP_ALL):
        # write files registered for generation
        any = False
        for id, entry in sorted(pycompat.iteritems(self._filegenerators)):
            any = True
            order, filenames, genfunc, location = entry

            # for generation at closing, check if it's before or after finalize
            postfinalize = group == GEN_GROUP_POST_FINALIZE
            if (
                group != GEN_GROUP_ALL
                and (id in postfinalizegenerators) != postfinalize
            ):
                continue

            vfs = self._vfsmap[location]
            files = []
            try:

44407:f6798c1a80fa

            del self._filegenerators[genid]

    def _generatefiles(self, suffix=b'', group=GEN_GROUP_ALL):
        # write files registered for generation
        any = False

        if group == GEN_GROUP_ALL:
            skip_post = skip_pre = False
        else:
            skip_pre = group == GEN_GROUP_POST_FINALIZE
            skip_post = group == GEN_GROUP_PRE_FINALIZE

        for id, entry in sorted(pycompat.iteritems(self._filegenerators)):
            any = True
            order, filenames, genfunc, location = entry

            # for generation at closing, check if it's before or after finalize
            is_post = id in postfinalizegenerators
            if skip_post and is_post:
                continue
            elif skip_pre and not is_post:
                continue

            vfs = self._vfsmap[location]
            files = []
            try: