Mercurial > hg
comparison contrib/phabricator.py @ 33785:f7d6978a4da9
phabricator: remove an unnecessary writediffproperties call
This was introduced by D229. Thanks Yuya for finding it!
Differential Revision: https://phab.mercurial-scm.org/D366
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Sat, 12 Aug 2017 21:40:48 -0700 |
| parents | e6d8ee3c9ec3 |
| children | fa3aa6c98bb7 |
comparison
equal
deleted
inserted
replaced
| 33784:589fda7895da | 33785:f7d6978a4da9 |
|---|---|
| 275 neednewdiff = True | 275 neednewdiff = True |
| 276 | 276 |
| 277 transactions = [] | 277 transactions = [] |
| 278 if neednewdiff: | 278 if neednewdiff: |
| 279 diff = creatediff(ctx) | 279 diff = creatediff(ctx) |
| 280 writediffproperties(ctx, diff) | |
| 281 transactions.append({'type': 'update', 'value': diff[r'phid']}) | 280 transactions.append({'type': 'update', 'value': diff[r'phid']}) |
| 282 else: | 281 else: |
| 283 # Even if we don't need to upload a new diff because the patch content | 282 # Even if we don't need to upload a new diff because the patch content |
| 284 # does not change. We might still need to update its metadata so | 283 # does not change. We might still need to update its metadata so |
| 285 # pushers could know the correct node metadata. | 284 # pushers could know the correct node metadata. |