comparison mercurial/subrepo.py @ 41494:fa7d4e6a0c98

subrepo: clean up lingering bytes/str issues in svn support

Path encoding is a little suspect in here, but it's not worse than it
was when we were on Python 2 only.

Subversion subrepo tests now pass in Python 3.

Differential Revision: https://phab.mercurial-scm.org/D5774

41493:97ab4cbb342e

                             bufsize=-1, close_fds=procutil.closefds,
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE,
                             universal_newlines=True,
                             env=procutil.tonativeenv(env), **extrakw)
        stdout, stderr = p.communicate()
        stderr = stderr.strip()
        if not failok:
            if p.returncode:
                raise error.Abort(stderr or 'exited with code %d'
                                  % p.returncode)

        # Get the working directory revision as well as the last
        # commit revision so we can compare the subrepo state with
        # both. We used to store the working directory one.
        output, err = self._svncommand(['info', '--xml'])
        doc = xml.dom.minidom.parseString(output)
        entries = doc.getElementsByTagName('entry')
        lastrev, rev = '0', '0'
        if entries:
            rev = str(entries[0].getAttribute('revision')) or '0'
            commits = entries[0].getElementsByTagName('commit')
            if commits:
                lastrev = str(commits[0].getAttribute('revision')) or '0'
        return (lastrev, rev)

    def _wcrev(self):
        return self._wcrevs()[0]

        is True if any change is a missing entry.
        """
        output, err = self._svncommand(['status', '--xml'])
        externals, changes, missing = [], [], []
        doc = xml.dom.minidom.parseString(output)
        for e in doc.getElementsByTagName('entry'):
            s = e.getElementsByTagName('wc-status')
            if not s:
                continue
            item = s[0].getAttribute('item')
            props = s[0].getAttribute('props')
            path = e.getAttribute('path')
            if item == 'external':
                externals.append(path)
            elif item == 'missing':
                missing.append(path)
            if (item not in ('', 'normal', 'unversioned', 'external')
                or props not in ('', 'none', 'normal')):
                changes.append(path)
        for path in changes:
            for ext in externals:
                if path == ext or path.startswith(ext + pycompat.ossep):
                    return True, True, bool(missing)

    @annotatesubrepoerror
    def files(self):
        output = self._svncommand(['list', '--recursive', '--xml'])[0]
        doc = xml.dom.minidom.parseString(output)
        paths = []
        for e in doc.getElementsByTagName('entry'):
            kind = pycompat.bytestr(e.getAttribute('kind'))
            if kind != 'file':
                continue
            name = ''.join(c.data for c
                           in e.getElementsByTagName('name')[0].childNodes
                           if c.nodeType == c.TEXT_NODE)
            paths.append(name.encode('utf-8'))
        return paths

    def filedata(self, name, decode):
        return self._svncommand(['cat'], name)[0]

41494:fa7d4e6a0c98

                             bufsize=-1, close_fds=procutil.closefds,
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE,
                             universal_newlines=True,
                             env=procutil.tonativeenv(env), **extrakw)
        stdout, stderr = p.communicate()
        stdout, stderr = pycompat.fsencode(stdout), pycompat.fsencode(stderr)
        stderr = stderr.strip()
        if not failok:
            if p.returncode:
                raise error.Abort(stderr or 'exited with code %d'
                                  % p.returncode)

        # Get the working directory revision as well as the last
        # commit revision so we can compare the subrepo state with
        # both. We used to store the working directory one.
        output, err = self._svncommand(['info', '--xml'])
        doc = xml.dom.minidom.parseString(output)
        entries = doc.getElementsByTagName(r'entry')
        lastrev, rev = '0', '0'
        if entries:
            rev = pycompat.bytestr(entries[0].getAttribute(r'revision')) or '0'
            commits = entries[0].getElementsByTagName(r'commit')
            if commits:
                lastrev = pycompat.bytestr(
                    commits[0].getAttribute(r'revision')) or '0'
        return (lastrev, rev)

    def _wcrev(self):
        return self._wcrevs()[0]

        is True if any change is a missing entry.
        """
        output, err = self._svncommand(['status', '--xml'])
        externals, changes, missing = [], [], []
        doc = xml.dom.minidom.parseString(output)
        for e in doc.getElementsByTagName(r'entry'):
            s = e.getElementsByTagName(r'wc-status')
            if not s:
                continue
            item = s[0].getAttribute(r'item')
            props = s[0].getAttribute(r'props')
            path = e.getAttribute(r'path').encode('utf8')
            if item == r'external':
                externals.append(path)
            elif item == r'missing':
                missing.append(path)
            if (item not in (r'', r'normal', r'unversioned', r'external')
                or props not in (r'', r'none', r'normal')):
                changes.append(path)
        for path in changes:
            for ext in externals:
                if path == ext or path.startswith(ext + pycompat.ossep):
                    return True, True, bool(missing)

    @annotatesubrepoerror
    def files(self):
        output = self._svncommand(['list', '--recursive', '--xml'])[0]
        doc = xml.dom.minidom.parseString(output)
        paths = []
        for e in doc.getElementsByTagName(r'entry'):
            kind = pycompat.bytestr(e.getAttribute(r'kind'))
            if kind != 'file':
                continue
            name = r''.join(c.data for c
                            in e.getElementsByTagName(r'name')[0].childNodes
                            if c.nodeType == c.TEXT_NODE)
            paths.append(name.encode('utf8'))
        return paths

    def filedata(self, name, decode):
        return self._svncommand(['cat'], name)[0]