Mercurial > hg
comparison mercurial/help.py @ 41009:fcc0a7ac9ebd
help: show "[no-]" only for default-on Flags
As Anton (av6) pointed out, the "[no-]" is confusing for action flags
like `hg bookmark --delete`. We could come up with a way of indicating
which flags are action flags (e.g. use None for the default value
instead of False). However, it's probably also unlikely that users
will want to negate even non-action flags like --hidden.
One of the more common flags where the "[no-]" prefix would be useful
is `hg evolve --update`. The reason it's helpful there is that it
defaults to on. So I think we can simply include "[no-]" only for
flags that are on by default (and thus require the user to add the
"[no-]" for the option to have any effect).
Note that there are use cases for negating flags that already off by
default. For example, you may have an alias for `hg log -G --hidden -T
foo` and now want to pass "--no-hidden" to that alias. However, I
think that users who want that are likely to be advanced enough that
they've already learnt about the "no-" prefix by seeing it somewhere
else.
Differential Revision: https://phab.mercurial-scm.org/D5454
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Wed, 19 Dec 2018 09:20:32 -0800 |
parents | f6187e60f792 |
children | e8e2a7656e83 |
comparison
equal
deleted
inserted
replaced
41008:e5d37558098a | 41009:fcc0a7ac9ebd |
---|---|
158 | 158 |
159 so = '' | 159 so = '' |
160 if shortopt: | 160 if shortopt: |
161 so = '-' + shortopt | 161 so = '-' + shortopt |
162 lo = '--' + longopt | 162 lo = '--' + longopt |
163 if isinstance(default, bool): | 163 if default is True: |
164 lo = '--[no-]' + longopt | 164 lo = '--[no-]' + longopt |
165 | 165 |
166 if isinstance(default, fancyopts.customopt): | 166 if isinstance(default, fancyopts.customopt): |
167 default = default.getdefaultvalue() | 167 default = default.getdefaultvalue() |
168 if (default and not callable(default)) or default is False: | 168 if (default and not callable(default)) or default is False: |