comparison mercurial/simplemerge.py @ 46099:fd75e5c53ec3

simplemerge: avoid quadratic concatenation when building output text

I haven't checked if the difference is measurable, but the new version
is no less readable or idiomatic, so I don't think performance numbers
are needed.

Differential Revision: https://phab.mercurial-scm.org/D9549

46098:5510e2ac213f

    elif name_base is not None:
        extrakwargs[b'base_marker'] = b'|||||||'
        extrakwargs[b'name_base'] = name_base
        extrakwargs[b'minimize'] = False

    mergedtext = b""
    for line in m3.merge_lines(
        name_a=name_a, name_b=name_b, **pycompat.strkwargs(extrakwargs)
    ):
        if opts.get('print'):
            ui.fout.write(line)
        else:
            mergedtext += line

    # merge flags if necessary
    flags = localctx.flags()
    localflags = set(pycompat.iterbytestr(flags))
    otherflags = set(pycompat.iterbytestr(otherctx.flags()))

        commonflags = localflags & otherflags
        addedflags = (localflags ^ otherflags) - baseflags
        flags = b''.join(sorted(commonflags | addedflags))

    if not opts.get('print'):
        localctx.write(mergedtext, flags)

    if m3.conflicts and not mode == b'union':
        return 1

46099:fd75e5c53ec3

    elif name_base is not None:
        extrakwargs[b'base_marker'] = b'|||||||'
        extrakwargs[b'name_base'] = name_base
        extrakwargs[b'minimize'] = False

    lines = []
    for line in m3.merge_lines(
        name_a=name_a, name_b=name_b, **pycompat.strkwargs(extrakwargs)
    ):
        if opts.get('print'):
            ui.fout.write(line)
        else:
            lines.append(line)

    # merge flags if necessary
    flags = localctx.flags()
    localflags = set(pycompat.iterbytestr(flags))
    otherflags = set(pycompat.iterbytestr(otherctx.flags()))

        commonflags = localflags & otherflags
        addedflags = (localflags ^ otherflags) - baseflags
        flags = b''.join(sorted(commonflags | addedflags))

    if not opts.get('print'):
        mergedtext = b''.join(lines)
        localctx.write(mergedtext, flags)

    if m3.conflicts and not mode == b'union':
        return 1