comparison mercurial/obsolete.py @ 38708:ff1182d166a2

obsolete: explode if metadata contains invalid UTF-8 sequence (API)

The current metadata API can be a source of bugs since it forces callers to
process encoding conversion by themselves. So let's make it reject bad data
as a last ditch. I assume there's no metadata field which is supposed to store
arbitrary BLOB like transplant_source.

38707:6b5ca1d0aa1e

    error,
    node,
    obsutil,
    phases,
    policy,
    util,
)
from .utils import dateutil

parsers = policy.importmod(r'parsers')

                raise ValueError(succ)
        if prec in succs:
            raise ValueError(_('in-marker cycle with %s') % node.hex(prec))

        metadata = tuple(sorted(metadata.iteritems()))

        marker = (bytes(prec), tuple(succs), int(flag), metadata, date, parents)
        return bool(self.add(transaction, [marker]))

    def add(self, transaction, markers):

38708:ff1182d166a2

    error,
    node,
    obsutil,
    phases,
    policy,
    pycompat,
    util,
)
from .utils import dateutil

parsers = policy.importmod(r'parsers')

                raise ValueError(succ)
        if prec in succs:
            raise ValueError(_('in-marker cycle with %s') % node.hex(prec))

        metadata = tuple(sorted(metadata.iteritems()))
        for k, v in metadata:
            try:
                # might be better to reject non-ASCII keys
                k.decode('utf-8')
                v.decode('utf-8')
            except UnicodeDecodeError:
                raise error.ProgrammingError(
                    'obsstore metadata must be valid UTF-8 sequence '
                    '(key = %r, value = %r)'
                    % (pycompat.bytestr(k), pycompat.bytestr(v)))

        marker = (bytes(prec), tuple(succs), int(flag), metadata, date, parents)
        return bool(self.add(transaction, [marker]))

    def add(self, transaction, markers):