comparison tests/test-phabricator.t @ 44128:ff396501e841

phabricator: use .arcconfig for `phabricator.url` if not set locally This setting is also per repo; see the previous commit for details. The existing `conduit_uri` setting is the previous name of `phabricator.uri`[1] and while it could easily be queried before the latter for compatibility, the config in this repo has '/api' appended. That's already done in `callconduit()`, which would clearly end up giving the wrong result. It looks like the path of the URL is now ignored in user configs[2], so add the modern setting without it to this repo's .arcconfig. Sadly, we still need to have contributors configure `auth.hg.phabtoken` (and therefore `auth.hg.prefix` to link it to `phabricator.url`) in order to submit patches, but at least now it's localized to a single section. [1] https://secure.phabricator.com/book/phabricator/article/arcanist_new_project/ [2] https://github.com/phacility/arcanist/blob/cc850163f30c4697e925df0d6212469679600a2c/scripts/arcanist.php#L271 Differential Revision: https://phab.mercurial-scm.org/D7935
author Matt Harbison <matt_harbison@yahoo.com>
date Fri, 17 Jan 2020 16:56:49 -0500
parents 59b3fe1e2021
children 5d85e9ddc7b9
comparison
equal deleted inserted replaced
44127:59b3fe1e2021 44128:ff396501e841
226 > EOF 226 > EOF
227 $ cp $TESTDIR/../.arcconfig . 227 $ cp $TESTDIR/../.arcconfig .
228 $ mv .hg/hgrc .hg/hgrc.bak 228 $ mv .hg/hgrc .hg/hgrc.bak
229 $ hg config phabricator --debug 229 $ hg config phabricator --debug
230 read config from: */.hgrc (glob) 230 read config from: */.hgrc (glob)
231 */.hgrc:*: phabricator.url=global (glob)
232 $TESTTMP/repo/.arcconfig: phabricator.callsign=HG 231 $TESTTMP/repo/.arcconfig: phabricator.callsign=HG
232 $TESTTMP/repo/.arcconfig: phabricator.url=https://phab.mercurial-scm.org/
233 233
234 But it doesn't override local config 234 But it doesn't override local config
235 $ cat >> .hg/hgrc << EOF 235 $ cat >> .hg/hgrc << EOF
236 > [phabricator] 236 > [phabricator]
237 > url = local 237 > url = local