diff i18n/hggettext @ 36948:0585337ea787

cleanup: fix some latent open(path).read() et al calls we previously missed

This pattern was banned by check-code way back in 1b4b82063ce2 (may of
2011), but due to a regular expression rewriting bug in check-code
these particular callsites were never detected. Python 3.7 caught the
bug, which then exposed these errors.

Differential Revision: https://phab.mercurial-scm.org/D2863

--- a/i18n/hggettext	Wed Mar 14 11:16:45 2018 -0700
+++ b/i18n/hggettext	Wed Mar 14 15:39:28 2018 -0400
@@ -104,7 +104,8 @@
     """
     mod = importpath(path)
     if not path.startswith('mercurial/') and mod.__doc__:
-        src = open(path).read()
+        with open(path) as fobj:
+            src = fobj.read()
         lineno = 1 + offset(src, mod.__doc__, path, 7)
         print(poentry(path, lineno, mod.__doc__))
 
@@ -143,7 +144,8 @@
 
 
 def rawtext(path):
-    src = open(path).read()
+    with open(path) as f:
+        src = f.read()
     print(poentry(path, 1, src))