Mercurial > hg

diff tests/f @ 36948:0585337ea787

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cleanup: fix some latent open(path).read() et al calls we previously missed This pattern was banned by check-code way back in 1b4b82063ce2 (may of 2011), but due to a regular expression rewriting bug in check-code these particular callsites were never detected. Python 3.7 caught the bug, which then exposed these errors. Differential Revision: https://phab.mercurial-scm.org/D2863
author Augie Fackler <augie@google.com>
date Wed, 14 Mar 2018 15:39:28 -0400
parents c69e78ef2b54
children 06c85cbd6824
line wrap: on
line diff
--- a/tests/f	Wed Mar 14 11:16:45 2018 -0700
+++ b/tests/f	Wed Mar 14 15:39:28 2018 -0400
@@ -61,7 +61,8 @@
             if opts.type:
                 facts.append(b'file')
             if any((opts.hexdump, opts.dump, opts.md5, opts.sha1, opts.sha256)):
-                content = open(f, 'rb').read()
+                with open(f, 'rb') as fobj:
+                    content = fobj.read()
         elif islink:
             if opts.type:
                 facts.append(b'link')