Mercurial > hg

diff contrib/check-code.py @ 34061:11499bad0359

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: forbid "\S" in egrep regular expression BSD `egrep` does not like it. So let's forbid it. Differential Revision: https://phab.mercurial-scm.org/D610
author Jun Wu <quark@fb.com>
date Fri, 01 Sep 2017 16:44:30 -0700
parents e267d4ee4f2d
children ba6e14f9a2d8
line wrap: on
line diff
--- a/contrib/check-code.py	Fri Sep 01 15:47:32 2017 -0700
+++ b/contrib/check-code.py	Fri Sep 01 16:44:30 2017 -0700
@@ -119,6 +119,7 @@
     (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),
     (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
      "use egrep for extended grep syntax"),
+    (r'(^|\|\s*)e?grep .*\\S', "don't use \\S in regular expression"),
     (r'(?<!!)/bin/', "don't use explicit paths for tools"),
     (r'#!.*/bash', "don't use bash in shebang, use sh"),
     (r'[^\n]\Z', "no trailing newline"),