diff mercurial/bookmarks.py @ 14168:135e244776f0

prevent transient leaks of file handle by using new helper functions

These leaks may occur in environments that don't employ a reference
counting GC, i.e. PyPy.

This implies:
 - changing opener(...).read() calls to opener.read(...)
 - changing opener(...).write() calls to opener.write(...)
 - changing open(...).read(...) to util.readfile(...)
 - changing open(...).write(...) to util.writefile(...)

--- a/mercurial/bookmarks.py	Mon May 02 10:11:05 2011 +0200
+++ b/mercurial/bookmarks.py	Mon May 02 10:11:18 2011 +0200
@@ -72,12 +72,12 @@
     refs = repo._bookmarks
 
     try:
-        bms = repo.opener('bookmarks').read()
+        bms = repo.opener.read('bookmarks')
     except IOError, inst:
         if inst.errno != errno.ENOENT:
             raise
         bms = ''
-    repo.opener('undo.bookmarks', 'w').write(bms)
+    repo.opener.write('undo.bookmarks', bms)
 
     if repo._bookmarkcurrent not in refs:
         setcurrent(repo, None)