Mercurial > hg
diff mercurial/dagop.py @ 39816:1cf1680b0554
keepalive: be more careful about self._rbuf when calling super impls
In Python 3, HTTPResponse implements read() in terms of readinto(),
which was calling back into our readinto(), which duplicates
self._rbuf if it's not empty. Before calling into super's read(),
ensure self._rbuf is empty.
Inheritance is bad, and undocumented self-use of your public API is
one of many reasons.
Differential Revision: https://phab.mercurial-scm.org/D4728
author | Augie Fackler <augie@google.com> |
---|---|
date | Mon, 24 Sep 2018 22:45:32 -0400 |
parents | 5362c96f2feb |
children | 0b24fcd88066 |