Mercurial > hg

diff contrib/check-code.py @ 25142:24140873ca4c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: lift the ban on 'next()' 'next' is supported by Python2.6 the new lowest version supported by Mercurial.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Sun, 17 May 2015 17:47:42 -0700
parents 3ea8d6b5e665
children 3b5cd6f13dcc
line wrap: on
line diff
--- a/contrib/check-code.py	Sun May 17 17:45:47 2015 -0700
+++ b/contrib/check-code.py	Sun May 17 17:47:42 2015 -0700
@@ -217,8 +217,6 @@
     (r'(\w|\)),\w', "missing whitespace after ,"),
     (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),
     (r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),
-    (r'(?<!def)(\s+|^|\()next\(.+\)',
-     'no next(foo) in Python 2.4 and 2.5, use foo.next() instead'),
     (r'(\s+)try:\n((?:\n|\1\s.*\n)*?)\1\s*yield\b.*?'
      r'((?:\n|\1\s.*\n)+?)\1finally:',
      'no yield inside try/finally in Python 2.4'),