diff mercurial/commands.py @ 46950:279df499511e

incoming: kill the `repo._subtoppath =` hack

We do the same as for `hg outgoing`, instead of relying on implicit passing
value by monkey punching them onto the repo object, we pass equivalent
information by argument to the proper function.

This is way cleaner.

Differential Revision: https://phab.mercurial-scm.org/D10416

--- a/mercurial/commands.py	Wed Apr 14 17:29:27 2021 +0200
+++ b/mercurial/commands.py	Wed Apr 14 17:41:02 2021 +0200
@@ -4351,11 +4351,7 @@
             finally:
                 other.close()
 
-    repo._subtoppath = ui.expandpath(source)
-    try:
-        return hg.incoming(ui, repo, source, opts)
-    finally:
-        del repo._subtoppath
+    return hg.incoming(ui, repo, source, opts)
 
 
 @command(