diff mercurial/tags.py @ 34015:2d80e078724a

tag: use filtered repo when creating new tags (issue5539)

When pruning a changeset that added a tag and then adding another tag, the
"pruned" tag gets restored. This is because the tag creation step (tags._tag()
call in tags.tag()) is currently done on the unfiltered repo. This behavior
has been there from 7977d35df13b which backs out b08af8f0ac01 with no clear
reason but caution on unthought situations at that time. In this changeset, we
pass the filtered repo to tags._tag(), preventing "pruned" tags to reappear.
This somehow restores b08af8f0ac01, though now we arguably have a valid use
case for.

--- a/mercurial/tags.py	Mon Aug 21 16:46:05 2017 -0700
+++ b/mercurial/tags.py	Tue Aug 29 11:25:22 2017 +0200
@@ -541,7 +541,7 @@
 
     with repo.wlock():
         repo.tags() # instantiate the cache
-        _tag(repo.unfiltered(), names, node, message, local, user, date,
+        _tag(repo, names, node, message, local, user, date,
              editor=editor)
 
 def _tag(repo, names, node, message, local, user, date, extra=None,