diff contrib/check-code.py @ 34573:3e4b7861c1c5

contrib: add check-code rule banning use of readlink readlink doesn't always exist, such as on Solaris-derived platforms. Differential Revision: https://phab.mercurial-scm.org/D1000
author Augie Fackler <augie@google.com>
date Wed, 11 Oct 2017 03:48:11 -0700
parents b521b3a79afd
children a679aa582d8d
line wrap: on
line diff
--- a/contrib/check-code.py	Tue Oct 10 11:03:14 2017 -0400
+++ b/contrib/check-code.py	Wed Oct 11 03:48:11 2017 -0700
@@ -203,6 +203,7 @@
      'use test -f to test for file existence'),
     (r'^  diff -[^ -]*p',
      "don't use (external) diff with -p for portability"),
+    (r' readlink ', 'use readlink.py instead of readlink'),
     (r'^  [-+][-+][-+] .* [-+]0000 \(glob\)',
      "glob timezone field in diff output for portability"),
     (r'^  @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',