Mercurial > hg
diff i18n/check-translation.py @ 26852:3fb36dec1727 stable
i18n: do not abuse msgstr of "DEPRECATED" to check for bad translation
Because 44cc9f63a2f1 requires the msgstr of "(DEPRECATED)", old *.po files
must be blamed. Using "DEPRECATED" would just hide the error.
For example, "LANG=da_DK.UTF-8 hg help serve" fails to hide deprecated
options right now, but check-translation.py couldn't detect it because
da.po has outdated translation of "DEPRECATED".
author | Yuya Nishihara <yuya@tcha.org> |
---|---|
date | Tue, 03 Nov 2015 22:39:26 +0900 |
parents | 47dd34f2e727 |
children | 29238dbf718e |
line wrap: on
line diff
--- a/i18n/check-translation.py Sun Nov 01 13:04:14 2015 -0600 +++ b/i18n/check-translation.py Tue Nov 03 22:39:26 2015 +0900 @@ -71,9 +71,7 @@ deprecatedpe = None @scanner() def deprecatedsetup(pofile): - pes = [p for p in pofile - if ((p.msgid == 'DEPRECATED' or p.msgid == '(DEPRECATED)') and - p.msgstr)] + pes = [p for p in pofile if p.msgid == '(DEPRECATED)' and p.msgstr] if len(pes): global deprecatedpe deprecatedpe = pes[0] @@ -82,8 +80,8 @@ def deprecated(pe): """Check for DEPRECATED >>> ped = polib.POEntry( - ... msgid = 'DEPRECATED', - ... msgstr= 'DETACERPED') + ... msgid = '(DEPRECATED)', + ... msgstr= '(DETACERPED)') >>> deprecatedsetup([ped]) >>> pe = polib.POEntry( ... msgid = 'Something (DEPRECATED)',