Mercurial > hg
diff hgext/phabricator.py @ 42433:500b64c5d991
phabricator: pass ui into readurltoken instead of passing repo
The goal of this series is to make `hg debugcallconduit` work outside of a hg
repo.
This patch, removes requirement of repo object from readurltoken as we only need
ui there. It also updates the callers to pass in ui instead of repo.
Differential Revision: https://phab.mercurial-scm.org/D6497
author | Pulkit Goyal <pulkit@yandex-team.ru> |
---|---|
date | Sat, 08 Jun 2019 18:32:12 +0300 |
parents | 29528c4235a1 |
children | f163e2b2594c |
line wrap: on
line diff
--- a/hgext/phabricator.py Sat Jun 08 19:20:31 2019 +0300 +++ b/hgext/phabricator.py Sat Jun 08 18:32:12 2019 +0300 @@ -183,24 +183,24 @@ process(b'', params) return util.urlreq.urlencode(flatparams) -def readurltoken(repo): +def readurltoken(ui): """return conduit url, token and make sure they exist Currently read from [auth] config section. In the future, it might make sense to read from .arcconfig and .arcrc as well. """ - url = repo.ui.config(b'phabricator', b'url') + url = ui.config(b'phabricator', b'url') if not url: raise error.Abort(_(b'config %s.%s is required') % (b'phabricator', b'url')) - res = httpconnectionmod.readauthforuri(repo.ui, url, util.url(url).user) + res = httpconnectionmod.readauthforuri(ui, url, util.url(url).user) token = None if res: group, auth = res - repo.ui.debug(b"using auth.%s.* for authentication\n" % group) + ui.debug(b"using auth.%s.* for authentication\n" % group) token = auth.get(b'phabtoken') @@ -212,7 +212,7 @@ def callconduit(repo, name, params): """call Conduit API, params is a dict. return json.loads result, or None""" - host, token = readurltoken(repo) + host, token = readurltoken(repo.ui) url, authinfo = util.url(b'/'.join([host, b'api', name])).authinfo() repo.ui.debug(b'Conduit Call: %s %s\n' % (url, pycompat.byterepr(params))) params = params.copy() @@ -653,7 +653,7 @@ (b'parent', b'Parent ')]) def _confirmbeforesend(repo, revs, oldmap): - url, token = readurltoken(repo) + url, token = readurltoken(repo.ui) ui = repo.ui for rev in revs: ctx = repo[rev]