Mercurial > hg

diff hgext/largefiles/lfutil.py @ 19002:5083baa6cbf8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
largefiles: remove blecch from lfutil.copyandhash - don't close the passed fd
author Mads Kiilerich <madski@unity3d.com>
date Mon, 15 Apr 2013 23:43:50 +0200
parents 2a35296a6304
children 1b84047e7d16
line wrap: on
line diff
--- a/hgext/largefiles/lfutil.py	Mon Apr 15 23:43:44 2013 +0200
+++ b/hgext/largefiles/lfutil.py	Mon Apr 15 23:43:50 2013 +0200
@@ -289,18 +289,11 @@
 
 def copyandhash(instream, outfile):
     '''Read bytes from instream (iterable) and write them to outfile,
-    computing the SHA-1 hash of the data along the way.  Close outfile
-    when done and return the hash.'''
+    computing the SHA-1 hash of the data along the way. Return the hash.'''
     hasher = util.sha1('')
     for data in instream:
         hasher.update(data)
         outfile.write(data)
-
-    # Blecch: closing a file that somebody else opened is rude and
-    # wrong. But it's so darn convenient and practical! After all,
-    # outfile was opened just to copy and hash.
-    outfile.close()
-
     return hasher.hexdigest()
 
 def hashrepofile(repo, file):