Mercurial > hg
diff hgext/largefiles/lfcommands.py @ 48116:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 28 Sep 2021 08:47:11 -0700 |
parents | 82e142b9ad18 |
children | df3021c1f093 |
line wrap: on
line diff
--- a/hgext/largefiles/lfcommands.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/largefiles/lfcommands.py Tue Sep 28 08:47:11 2021 -0700 @@ -26,6 +26,7 @@ exthelper, hg, lock, + logcmdutil, match as matchmod, pycompat, scmutil, @@ -657,7 +658,7 @@ revs = opts.get('rev', []) if not revs: raise error.Abort(_(b'no revisions specified')) - revs = scmutil.revrange(repo, revs) + revs = logcmdutil.revrange(repo, revs) numcached = 0 for rev in revs: