Mercurial > hg
diff hgext/split.py @ 48116:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 28 Sep 2021 08:47:11 -0700 |
parents | ca0049946e9a |
children | 6000f5b25c9b |
line wrap: on
line diff
--- a/hgext/split.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/split.py Tue Sep 28 08:47:11 2021 -0700 @@ -22,6 +22,7 @@ commands, error, hg, + logcmdutil, pycompat, registrar, revsetlang, @@ -75,7 +76,7 @@ # If the rebase somehow runs into conflicts, make sure # we close the transaction so the user can continue it. with util.acceptintervention(tr): - revs = scmutil.revrange(repo, revlist or [b'.']) + revs = logcmdutil.revrange(repo, revlist or [b'.']) if len(revs) > 1: raise error.InputError(_(b'cannot split multiple revisions'))