Mercurial > hg
diff mercurial/httppeer.py @ 27571:6a6e78f84cc6 stable
merge: while checking for unknown files don't follow symlinks (issue5027)
Previously, we were using Python's native 'os.path.isfile' method which follows
symlinks. In this case, since we're operating on repo contents, we don't want
to follow symlinks.
There's a behaviour change here, as shown by the second part of the added test.
Consider a symlink 'f' pointing to a file containing 'abc'. If we try and
replace it with a file with contents 'abc', previously we would have let it
though. Now we don't. Although this breaks naive inspection with tools like
'cat' and 'diff', on balance I believe this is the right change.
author | Siddharth Agarwal <sid0@fb.com> |
---|---|
date | Mon, 28 Dec 2015 22:51:37 -0800 |
parents | 56b2bcea2529 |
children | b502138f5faa |