diff tests/get-with-headers.py @ 47582:6bceecb28806

windows: make sure we fully read and cleanly close the connection Maybe this will prevent server on Windows to sometimes complains about the client closing the connection too soon. So we make sure we read everything and we officially close the connection. Hopefully Windows will be happier and the test will stop being flaky. Differential Revision: https://phab.mercurial-scm.org/D11073
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Sat, 10 Jul 2021 17:19:07 +0200
parents 23f5ed6dbcb1
children 6000f5b25c9b
line wrap: on
line diff
--- a/tests/get-with-headers.py	Sat Jul 10 02:42:09 2021 +0200
+++ b/tests/get-with-headers.py	Sat Jul 10 17:19:07 2021 +0200
@@ -84,7 +84,11 @@
                 b"%s: %s\n"
                 % (h.encode('ascii'), response.getheader(h).encode('ascii'))
             )
-    if not headeronly:
+    if headeronly:
+        # still read the body to prevent windows to be unhappy about that
+        # (this might some flakyness in test-hgweb-filelog.t on Windows)
+        data = response.read()
+    else:
         stdout.write(b'\n')
         data = response.read()
 
@@ -112,6 +116,9 @@
     if twice and response.getheader('ETag', None):
         tag = response.getheader('ETag')
 
+    # further try to please the windows-flakyness deity
+    conn.close()
+
     return response.status