diff mercurial/pathutil.py @ 29889:6f447b9ec263

util: rename checkcase() to fscasesensitive() (API)

I always read the name "checkcase(path)" as "do we need to check for
case folding at this path", but it's actually (I think) meant to be
read "check if the file system cares about case at this path". I'm
clearly not the only one confused by this as the dirstate has this
property:

  def _checkcase(self):
      return not util.checkcase(self._join('.hg'))

Maybe we should even inverse the function and call it fscasefolding()
since that's what all callers care about?

--- a/mercurial/pathutil.py	Mon Aug 29 17:48:14 2016 -0700
+++ b/mercurial/pathutil.py	Tue Aug 30 09:22:53 2016 -0700
@@ -40,7 +40,7 @@
         self.root = root
         self._realfs = realfs
         self.callback = callback
-        if os.path.lexists(root) and not util.checkcase(root):
+        if os.path.lexists(root) and not util.fscasesensitive(root):
             self.normcase = util.normcase
         else:
             self.normcase = lambda x: x