diff tests/test-generaldelta.t @ 51352:7083b33a2699

delta-find: explicitly deal with usage of the cached revision

We can remove this from the general logic path and directly deal with this
corner case early.

This result in a small change in test-generaldelta.t as it turns out that:

- at commit time we (sometimes) precompute a delta against p1 and pass it as the
  cached delta.
- since cached delta where going through the same filtering as everything, we
  could "optimize" the base if it applied to an empty delta, resulting in not
  using the pre-computed delta.

The simpler logic fix the second item, making the cached delta base always actually
tested when requested.

Note that the computation of a fast delta against p1 only is questionable, but
looking into that is out of scope for this series.

--- a/tests/test-generaldelta.t	Sun Jan 07 03:02:30 2024 +0100
+++ b/tests/test-generaldelta.t	Sun Jan 07 03:08:46 2024 +0100
@@ -271,7 +271,7 @@
        51      17      -1       4        3       50    prev        3??        5??        6??   1.0????       6??         0    0.00000 (glob)
        52      51      -1       4        4       51      p1         58        640        6??   1.0????       6??         0    0.00000 (glob)
        53      52      -1       5        1       -1    base          0          0          0   0.00000         0         0    0.00000
-       54      53      -1       6        1       -1    base        3??        640        3??   0.5????       3??         0    0.00000 (glob)
+       54      53      -1       5        2       53      p1        3??        640        3??   0.5????       3??         0    0.00000 (glob)
   $ hg clone --pull source-repo --config experimental.maxdeltachainspan=2800 relax-chain --config format.generaldelta=yes
   requesting all changes
   adding changesets