diff mercurial/revset.py @ 23127:7361d8244efb stable

addset: fix `first` and `last` on sorted addset (issue4426) The lazy sorting were not enforced on addset. This was made visible through MQ.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Sat, 01 Nov 2014 22:58:30 +0000
parents c23c03605c59
children e53f6b72a0e4 0c432696dae3
line wrap: on
line diff
--- a/mercurial/revset.py	Sat Nov 01 17:30:57 2014 -0500
+++ b/mercurial/revset.py	Sat Nov 01 22:58:30 2014 +0000
@@ -2642,14 +2642,15 @@
             self._ascending = not self._ascending
 
     def first(self):
-        if self:
-            return self._list.first()
+        for x in self:
+            return x
         return None
 
     def last(self):
-        if self:
-            return self._list.last()
-        return None
+        self.reverse()
+        val = self.first()
+        self.reverse()
+        return val
 
 class generatorset(abstractsmartset):
     """Wrap a generator for lazy iteration