diff mercurial/verify.py @ 39244:73cf21b2e8a6

manifest: add getstorage() to manifestlog and use it globally

It is a common pattern to obtain a directory manifest storage instance
(a manifestrevlog) by going through manifestlog._revlog.dirlog().

Why access to storage and caching of other manifests is done through
manifestrevlog instead of manifestlog, I don't know.

This commit establishes a getstorage(tree) API on manifestlog and
imanifestlog that provides a public API for accessing manifest storage.

All consumers previously using private attributes have been updated
to use this new method.

.. api:: manifestlog now has a getstorage(tree) method

   It should be used for obtaining an object representing the
   manifest's storage implementation. Accessing
   manifestlog._revlog should be avoided.

Differential Revision: https://phab.mercurial-scm.org/D4277

--- a/mercurial/verify.py	Fri Aug 10 14:44:50 2018 -0700
+++ b/mercurial/verify.py	Fri Aug 10 15:01:06 2018 -0700
@@ -45,7 +45,7 @@
         self.errors = 0
         self.warnings = 0
         self.havecl = len(repo.changelog) > 0
-        self.havemf = len(repo.manifestlog._revlog) > 0
+        self.havemf = len(repo.manifestlog.getstorage(b'')) > 0
         self.revlogv1 = repo.changelog.version != revlog.REVLOGV0
         self.lrugetctx = util.lrucachefunc(repo.__getitem__)
         self.refersmf = False
@@ -205,7 +205,7 @@
         ui = self.ui
         match = self.match
         mfl = self.repo.manifestlog
-        mf = mfl._revlog.dirlog(dir)
+        mf = mfl.getstorage(dir)
 
         if not dir:
             self.ui.status(_("checking manifests\n"))