diff contrib/synthrepo.py @ 43104:74802979dd9d

py3: define and use pycompat.itervalues()

.itervalues() only exists on Python 2. Python 3's equivalent is
.values(). But we don't want to blindly use .values() everywhere
because on Python 2, it will create a list, which will have performance
implications.

This commit introduces pycompat.itervalues() which will call the appropriate
method on the passed object. We update all callers of obj.itervalues()
to pycompat.itervalues(obj) instead.

With this commit, the only source tranforming remaining is for
iteritems(). Victory is near...

Differential Revision: https://phab.mercurial-scm.org/D7013

--- a/contrib/synthrepo.py	Sun Oct 06 17:45:05 2019 -0400
+++ b/contrib/synthrepo.py	Sun Oct 06 17:59:15 2019 -0400
@@ -213,7 +213,7 @@
             for filename, mar, lineadd, lineremove, isbin in parsegitdiff(diff):
                 if isbin:
                     continue
-                added = sum(lineadd.itervalues(), 0)
+                added = sum(pycompat.itervalues(lineadd), 0)
                 if mar == 'm':
                     if added and lineremove:
                         lineschanged[