Mercurial > hg
diff tests/test-rebase-conflicts.t @ 31225:749b057b01f3
rebase: allow aborting if last-message.txt is missing
Previously, if .hg/rebasestate existed but .hg/last-message.txt was missing, 'hg
rebase --abort' would say there's no rebase in progress but 'hg checkout foo'
would say 'abort: rebase in progress'. It turns out loading the collapse message
will throw a "no rebase in progress" error if the file doesn't exist, even
though .hg/rebasestate obviously indicates a rebase is in progress.
The fix is to only throw an exception if we're trying to --continue, and to just
eat the issues if we're doing --abort.
This issue is exposed by us writing the rebase state earlier in the process.
This will be used by later patches to ensure the user can appropriately 'hg
rebase --abort' if there's a crash before the first the first commit has
finished rebasing. Tests cover all of this. The only negative affect is we now
require a hg rebase --abort in a very specific exception case, as shown in the
test.
author | Durham Goode <durham@fb.com> |
---|---|
date | Tue, 07 Mar 2017 16:30:31 -0800 |
parents | ce3a133f71b3 |
children | cf8ad0e6c0e4 |
line wrap: on
line diff
--- a/tests/test-rebase-conflicts.t Tue Mar 07 14:04:29 2017 -0800 +++ b/tests/test-rebase-conflicts.t Tue Mar 07 16:30:31 2017 -0800 @@ -218,6 +218,7 @@ $ hg rebase -s9 -d2 --debug # use debug to really check merge base used rebase onto 4bc80088dc6b starting from e31216eec445 + rebase status stored ignoring null merge rebase of 3 ignoring null merge rebase of 4 ignoring null merge rebase of 6