Mercurial > hg

diff contrib/check-code.py @ 28884:75309badb485

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: reject import urllib
author timeless <timeless@mozdev.org>
date Thu, 07 Apr 2016 00:34:07 +0000
parents 9848a6c77a9b
children e05bdc01505f
line wrap: on
line diff
--- a/contrib/check-code.py	Wed Apr 06 23:22:12 2016 +0000
+++ b/contrib/check-code.py	Thu Apr 07 00:34:07 2016 +0000
@@ -316,6 +316,8 @@
     (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
     (r'\butil\.Abort\b', "directly use error.Abort"),
     (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
+    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
+    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
   ],
   # warnings
   [